]> git.baikalelectronics.ru Git - kernel.git/commitdiff
soundwire: debugfs: use controller id instead of link_id
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Fri, 15 Jan 2021 16:25:59 +0000 (16:25 +0000)
committerVinod Koul <vkoul@kernel.org>
Tue, 19 Jan 2021 14:51:21 +0000 (20:21 +0530)
link_id can be zero and if we have multiple controller instances
in a system like Qualcomm debugfs will end-up with duplicate namespace
resulting in incorrect debugfs entries.

Using id should give a unique debugfs directory entry and should fix below
warning too.
"debugfs: Directory 'master-0' with parent 'soundwire' already present!"

Fixes: bf03473d5bcc ("soundwire: add debugfs support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210115162559.20869-1-srinivas.kandagatla@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/debugfs.c

index b6cad0d59b7b9f2562d6a1c275315b10f5c02581..5f9efa42bb25be6762935f022610feeedd825d7a 100644 (file)
@@ -19,7 +19,7 @@ void sdw_bus_debugfs_init(struct sdw_bus *bus)
                return;
 
        /* create the debugfs master-N */
-       snprintf(name, sizeof(name), "master-%d", bus->link_id);
+       snprintf(name, sizeof(name), "master-%d", bus->id);
        bus->debugfs = debugfs_create_dir(name, sdw_debugfs_root);
 }