]> git.baikalelectronics.ru Git - kernel.git/commitdiff
dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 16 May 2020 21:42:05 +0000 (23:42 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 19 May 2020 16:56:01 +0000 (22:26 +0530)
Commit 788a95c3bccc ("dmaengine: tegra210-adma: Fix crash during probe")
has moved some code in the probe function and reordered the error handling
path accordingly.
However, a goto has been missed.

Fix it and goto the right label if 'dma_async_device_register()' fails, so
that all resources are released.

Fixes: 788a95c3bccc ("dmaengine: tegra210-adma: Fix crash during probe")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20200516214205.276266-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/tegra210-adma.c

index c4ce5dfb149b1a17c5ca04d9f7b573e9e4276674..db58d7e4f9fec992b84a9db283d7894e502a952b 100644 (file)
@@ -900,7 +900,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
        ret = dma_async_device_register(&tdma->dma_dev);
        if (ret < 0) {
                dev_err(&pdev->dev, "ADMA registration failed: %d\n", ret);
-               goto irq_dispose;
+               goto rpm_put;
        }
 
        ret = of_dma_controller_register(pdev->dev.of_node,