]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: caif: Add lockdep expression to RCU traversal primitive
authorAmol Grover <frextrite@gmail.com>
Thu, 12 Mar 2020 05:34:20 +0000 (11:04 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Mar 2020 05:55:25 +0000 (22:55 -0700)
caifdevs->list is traversed using list_for_each_entry_rcu()
outside an RCU read-side critical section but under the
protection of rtnl_mutex. Hence, add the corresponding lockdep
expression to silence the following false-positive warning:

[   10.868467] =============================
[   10.869082] WARNING: suspicious RCU usage
[   10.869817] 5.6.0-rc1-00177-g06ec0a154aae4 #1 Not tainted
[   10.870804] -----------------------------
[   10.871557] net/caif/caif_dev.c:115 RCU-list traversed in non-reader section!!

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Amol Grover <frextrite@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/caif/caif_dev.c

index 03c7cdd8e4cbfcfcbb9a1c66cae3f6803bde24a9..195d2d67be8a3043c48027a0a6e897660bd74072 100644 (file)
@@ -112,7 +112,8 @@ static struct caif_device_entry *caif_get(struct net_device *dev)
            caif_device_list(dev_net(dev));
        struct caif_device_entry *caifd;
 
-       list_for_each_entry_rcu(caifd, &caifdevs->list, list) {
+       list_for_each_entry_rcu(caifd, &caifdevs->list, list,
+                               lockdep_rtnl_is_held()) {
                if (caifd->netdev == dev)
                        return caifd;
        }