]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ASoC: tegra: Fix a NULL vs IS_ERR() check
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 18 Jun 2021 13:44:24 +0000 (16:44 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 21 Jun 2021 12:06:27 +0000 (13:06 +0100)
The tegra_machine_parse_phandle() function doesn't return NULL, it returns
error pointers.

Fixes: 368c78fe23f5 ("ASoC: tegra: Unify ASoC machine drivers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lore.kernel.org/r/YMyjOKFsPe9SietU@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/tegra/tegra_asoc_machine.c

index a53aec361a7714bd653fac30d27e8aaac5202700..735909310a262d3310647137401bb8c058dd8293 100644 (file)
@@ -409,7 +409,7 @@ int tegra_asoc_machine_probe(struct platform_device *pdev)
                return PTR_ERR(np_codec);
 
        np_i2s = tegra_machine_parse_phandle(dev, "nvidia,i2s-controller");
-       if (!np_i2s)
+       if (IS_ERR(np_i2s))
                return PTR_ERR(np_i2s);
 
        card->dai_link->cpus->of_node = np_i2s;