]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ksmbd: fix SMB 3.11 posix extension mount failure
authorNamjae Jeon <linkinjeon@kernel.org>
Sat, 22 Jan 2022 01:47:22 +0000 (10:47 +0900)
committerSteve French <stfrench@microsoft.com>
Mon, 24 Jan 2022 00:19:04 +0000 (18:19 -0600)
cifs client set 4 to DataLength of create_posix context, which mean
Mode variable of create_posix context is only available. So buffer
validation of ksmbd should check only the size of Mode except for
the size of Reserved variable.

Fixes: 6ca34401b445 ("ksmbd: add buffer validation for SMB2_CREATE_CONTEXT")
Cc: stable@vger.kernel.org # v5.15+
Reported-by: Steve French <smfrench@gmail.com>
Tested-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/ksmbd/smb2pdu.c

index 1866c81c5c99f000896686242e650951fc0ff1fb..3926ca18dca4c4f21d19fbcd7aebf2ff112af8df 100644 (file)
@@ -2688,7 +2688,7 @@ int smb2_open(struct ksmbd_work *work)
                                        (struct create_posix *)context;
                                if (le16_to_cpu(context->DataOffset) +
                                    le32_to_cpu(context->DataLength) <
-                                   sizeof(struct create_posix)) {
+                                   sizeof(struct create_posix) - 4) {
                                        rc = -EINVAL;
                                        goto err_out1;
                                }