drm/omap: remove checks for return value of drm_debugfs functions

Since 987d65d01356 (drm: debugfs: make
drm_debugfs_create_files() never fail), there is no need to ever check
the return value for drm_debugfs_create_files(). Therefore remove the
checks for the return value and subsequent error handling in
omap_debugfs_init().

These changes also enables the changing of omap_debugfs_init() to return
0 directly.

v2: convert omap_debugfs_init() to return 0 instead of void to avoid
introduction of build issues and enable individual driver compilation.

References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-14-wambui.karugax@gmail.com

diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c b/drivers/gpu/drm/omapdrm/omap_debugfs.c
index 34dfb33145b49f047a38adf9e9626d2ad6c52be4..ed63dcced79a60e28b96ec8fdeced9db89fc8ee4 100644 (file)
--- a/drivers/gpu/drm/omapdrm/omap_debugfs.c
+++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c
@@ -82,29 +82,16 @@ static struct drm_info_list omap_dmm_debugfs_list[] = {
 
 int omap_debugfs_init(struct drm_minor *minor)
 {
-       struct drm_device *dev = minor->dev;
-       int ret;
-
-       ret = drm_debugfs_create_files(omap_debugfs_list,
-                       ARRAY_SIZE(omap_debugfs_list),
-                       minor->debugfs_root, minor);
-
-       if (ret) {
-               dev_err(dev->dev, "could not install omap_debugfs_list\n");
-               return ret;
-       }
+       drm_debugfs_create_files(omap_debugfs_list,
+                                ARRAY_SIZE(omap_debugfs_list),
+                                minor->debugfs_root, minor);
 
        if (dmm_is_available())
-               ret = drm_debugfs_create_files(omap_dmm_debugfs_list,
-                               ARRAY_SIZE(omap_dmm_debugfs_list),
-                               minor->debugfs_root, minor);
+               drm_debugfs_create_files(omap_dmm_debugfs_list,
+                                        ARRAY_SIZE(omap_dmm_debugfs_list),
+                                        minor->debugfs_root, minor);
 
-       if (ret) {
-               dev_err(dev->dev, "could not install omap_dmm_debugfs_list\n");
-               return ret;
-       }
-
-       return ret;
+       return 0;
 }
 
 #endif