]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dsa: sja1105: error out on unsupported PHY mode
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 24 May 2021 09:25:25 +0000 (12:25 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 May 2021 20:20:24 +0000 (13:20 -0700)
The driver continues probing when a port is configured for an
unsupported PHY interface type, instead it should stop.

Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/sja1105/sja1105_main.c

index c7a1be8bbddfc47dc43116a1f293f0de0a9e5009..7f7e0424a442758792ee3773df3db6c29ee2133a 100644 (file)
@@ -207,6 +207,7 @@ static int sja1105_init_mii_settings(struct sja1105_private *priv,
                default:
                        dev_err(dev, "Unsupported PHY mode %s!\n",
                                phy_modes(ports[i].phy_mode));
+                       return -EINVAL;
                }
 
                /* Even though the SerDes port is able to drive SGMII autoneg