]> git.baikalelectronics.ru Git - kernel.git/commitdiff
firmware: arm_scmi: Fixup perf power-cost/microwatt support
authorSibi Sankar <quic_sibis@quicinc.com>
Fri, 11 Aug 2023 20:48:18 +0000 (02:18 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Oct 2023 12:56:46 +0000 (14:56 +0200)
[ Upstream commit c3638b851bc1ca0022dca9d6ca4beaa6ef03a216 ]

The perf power scale value would currently be reported as bogowatts if the
platform firmware supports microwatt power scale and meets the perf major
version requirements. Fix this by populating version information in the
driver private data before the call to protocol attributes is made.

CC: Chandra Sekhar Lingutla <quic_lingutla@quicinc.com>
Fixes: 3630cd8130ce ("firmware: arm_scmi: Add SCMI v3.1 perf power-cost in microwatts")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20230811204818.30928-1-quic_sibis@quicinc.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/firmware/arm_scmi/perf.c

index 43dd242ecc49c0b078bcc4a363b8ccee57863e9c..431bda9165c3d5c1b982bfa2eac4852c8f397d2b 100644 (file)
@@ -858,6 +858,8 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph)
        if (!pinfo)
                return -ENOMEM;
 
+       pinfo->version = version;
+
        ret = scmi_perf_attributes_get(ph, pinfo);
        if (ret)
                return ret;
@@ -877,8 +879,6 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph)
                        scmi_perf_domain_init_fc(ph, domain, &dom->fc_info);
        }
 
-       pinfo->version = version;
-
        return ph->set_priv(ph, pinfo);
 }