]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: qedi: Use QEDI_MODE_NORMAL for error handling
authorMike Christie <michael.christie@oracle.com>
Thu, 16 Jun 2022 22:27:37 +0000 (17:27 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 22 Jun 2022 01:14:54 +0000 (21:14 -0400)
When handling errors that lead to host removal use QEDI_MODE_NORMAL. There
is currently no difference in behavior between NORMAL and SHUTDOWN, but in
a subsequent commit we will want to know when we are called from the
pci_driver shutdown callout vs remove/err_handler so we know when userspace
is up.

Link: https://lore.kernel.org/r/20220616222738.5722-6-michael.christie@oracle.com
Tested-by: Nilesh Javali <njavali@marvell.com>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Reviewed-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedi/qedi_main.c

index 83ffba7f51da1896bc74ed19b45baaf52630cd73..deebe62e2b419379d9404277835cedca3b37d285 100644 (file)
@@ -2491,7 +2491,7 @@ static void qedi_board_disable_work(struct work_struct *work)
        if (test_and_set_bit(QEDI_IN_SHUTDOWN, &qedi->flags))
                return;
 
-       __qedi_remove(qedi->pdev, QEDI_MODE_SHUTDOWN);
+       __qedi_remove(qedi->pdev, QEDI_MODE_NORMAL);
 }
 
 static void qedi_shutdown(struct pci_dev *pdev)