]> git.baikalelectronics.ru Git - kernel.git/commitdiff
io_uring: fix off-by-one in BUILD_BUG_ON check of __REQ_F_LAST_BIT
authorHao Xu <haoxu@linux.alibaba.com>
Tue, 7 Sep 2021 03:22:43 +0000 (11:22 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 10 Sep 2021 12:24:51 +0000 (06:24 -0600)
Build check of __REQ_F_LAST_BIT should be larger than, not equal or larger
than. It's perfectly valid to have __REQ_F_LAST_BIT be 32, as that means
that the last valid bit is 31 which does fit in the type.

Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
Link: https://lore.kernel.org/r/20210907032243.114190-1-haoxu@linux.alibaba.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index ffd91844b2e5d65a34357c0ab829a233b9a93283..f795ad2810380537399c9fd480669c4abb4f5ed2 100644 (file)
@@ -10863,7 +10863,7 @@ static int __init io_uring_init(void)
        BUILD_BUG_ON(SQE_VALID_FLAGS >= (1 << 8));
 
        BUILD_BUG_ON(ARRAY_SIZE(io_op_defs) != IORING_OP_LAST);
-       BUILD_BUG_ON(__REQ_F_LAST_BIT >= 8 * sizeof(int));
+       BUILD_BUG_ON(__REQ_F_LAST_BIT > 8 * sizeof(int));
 
        req_cachep = KMEM_CACHE(io_kiocb, SLAB_HWCACHE_ALIGN | SLAB_PANIC |
                                SLAB_ACCOUNT);