]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: qedi: Remove redundant flush_workqueue() calls
authorMinghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Thu, 27 Jan 2022 01:39:34 +0000 (01:39 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 31 Jan 2022 22:09:44 +0000 (17:09 -0500)
destroy_workqueue() already drains the queue before destroying it, so there
is no need to flush it explicitly.

Remove the redundant flush_workqueue() calls.

Link: https://lore.kernel.org/r/20220127013934.1184923-1-chi.minghao@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedi/qedi_main.c

index 832a856dd367bc0f2ca8634919086e032a6b2918..83ffba7f51da1896bc74ed19b45baaf52630cd73 100644 (file)
@@ -2418,13 +2418,11 @@ static void __qedi_remove(struct pci_dev *pdev, int mode)
                iscsi_host_remove(qedi->shost);
 
                if (qedi->tmf_thread) {
-                       flush_workqueue(qedi->tmf_thread);
                        destroy_workqueue(qedi->tmf_thread);
                        qedi->tmf_thread = NULL;
                }
 
                if (qedi->offload_thread) {
-                       flush_workqueue(qedi->offload_thread);
                        destroy_workqueue(qedi->offload_thread);
                        qedi->offload_thread = NULL;
                }