]> git.baikalelectronics.ru Git - kernel.git/commitdiff
Makefile.debug: set -g unconditional on CONFIG_DEBUG_INFO_SPLIT
authorNick Desaulniers <ndesaulniers@google.com>
Mon, 19 Sep 2022 17:30:30 +0000 (10:30 -0700)
committerMasahiro Yamada <masahiroy@kernel.org>
Sat, 24 Sep 2022 02:12:54 +0000 (11:12 +0900)
Dmitrii, Fangrui, and Mashahiro note:

  Before GCC 11 and Clang 12 -gsplit-dwarf implicitly uses -g2.

Fix CONFIG_DEBUG_INFO_SPLIT for gcc-11+ & clang-12+ which now need -g
specified in order for -gsplit-dwarf to work at all.

-gsplit-dwarf has been mutually exclusive with -g since support for
CONFIG_DEBUG_INFO_SPLIT was introduced in
commit 866ced950bcd ("kbuild: Support split debug info v4")
I don't think it ever needed to be.

Link: https://lore.kernel.org/lkml/20220815013317.26121-1-dmitrii.bundin.a@gmail.com/
Link: https://lore.kernel.org/lkml/CAK7LNARPAmsJD5XKAw7m_X2g7Fi-CAAsWDQiP7+ANBjkg7R7ng@mail.gmail.com/
Link: https://reviews.llvm.org/D80391
Cc: Andi Kleen <ak@linux.intel.com>
Reported-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Reported-by: Fangrui Song <maskray@google.com>
Reported-by: Masahiro Yamada <masahiroy@kernel.org>
Suggested-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/Makefile.debug

index 9f39b0130551f3d35182df243a3fc9de38a1e264..26d6a9d97a20ed201941a7dda0b1637b1e92b5e3 100644 (file)
@@ -1,9 +1,7 @@
-DEBUG_CFLAGS   :=
+DEBUG_CFLAGS   := -g
 
 ifdef CONFIG_DEBUG_INFO_SPLIT
 DEBUG_CFLAGS   += -gsplit-dwarf
-else
-DEBUG_CFLAGS   += -g
 endif
 
 ifndef CONFIG_AS_IS_LLVM