]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: openvswitch: use div_u64() for 64-by-32 divisions
authorTonghao Zhang <xiangxia.m.yue@gmail.com>
Sat, 25 Apr 2020 03:39:48 +0000 (11:39 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 26 Apr 2020 03:48:21 +0000 (20:48 -0700)
Compile the kernel for arm 32 platform, the build warning found.
To fix that, should use div_u64() for divisions.
| net/openvswitch/meter.c:396: undefined reference to `__udivdi3'

[add more commit msg, change reported tag, and use div_u64 instead
of do_div by Tonghao]

Fixes: 1e1ccacc36c486f3 ("net: openvswitch: use u64 for meter bucket")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Tested-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/meter.c

index 612ad5586ce9abc74e755e5c72d6d0918f1313e2..3d3d8e0945468193bf37ea81992fa98ae17f2f27 100644 (file)
@@ -393,7 +393,7 @@ static struct dp_meter *dp_meter_create(struct nlattr **a)
                 * Start with a full bucket.
                 */
                band->bucket = (band->burst_size + band->rate) * 1000ULL;
-               band_max_delta_t = band->bucket / band->rate;
+               band_max_delta_t = div_u64(band->bucket, band->rate);
                if (band_max_delta_t > meter->max_delta_t)
                        meter->max_delta_t = band_max_delta_t;
                band++;