OPP: fix error checking in opp_migrate_dentry()

[ Upstream commit eca4c0eea53432ec4b711b2a8ad282cbad231b4f ]

Since commit 846632d286c9 ("debugfs: return error values,
not NULL") changed return value of debugfs_rename() in
error cases from %NULL to %ERR_PTR(-ERROR), we should
also check error values instead of NULL.

Fixes: 846632d286c9 ("debugfs: return error values, not NULL")
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c
index 609665e339b6b8d45b797c84fc11b14202ce1252..c7647410316e6bb3ca6b42ef2f612d843867d402 100644 (file)
--- a/drivers/opp/debugfs.c
+++ b/drivers/opp/debugfs.c
@@ -162,7 +162,7 @@ static void opp_migrate_dentry(struct opp_device *opp_dev,
 
        dentry = debugfs_rename(rootdir, opp_dev->dentry, rootdir,
                                opp_table->dentry_name);
-       if (!dentry) {
+       if (IS_ERR(dentry)) {
                dev_err(dev, "%s: Failed to rename link from: %s to %s\n",
                        __func__, dev_name(opp_dev->dev), dev_name(dev));
                return;