]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: plip: don't call kfree_skb/dev_kfree_skb() under spin_lock_irq()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 7 Dec 2022 01:53:10 +0000 (09:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Dec 2022 10:30:48 +0000 (11:30 +0100)
[ Upstream commit 7d8c19bfc8ff3f78e5337107ca9246327fcb6b45 ]

It is not allowed to call kfree_skb() or consume_skb() from
hardware interrupt context or with interrupts being disabled.
So replace kfree_skb/dev_kfree_skb() with dev_kfree_skb_irq()
and dev_consume_skb_irq() under spin_lock_irq().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20221207015310.2984909-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/plip/plip.c

index e8b7d596d7492538f424b311a9a280a25c5bf174..4b50c28f01a71cec3431ac1981edffc72dd4d4cc 100644 (file)
@@ -444,12 +444,12 @@ plip_bh_timeout_error(struct net_device *dev, struct net_local *nl,
        }
        rcv->state = PLIP_PK_DONE;
        if (rcv->skb) {
-               kfree_skb(rcv->skb);
+               dev_kfree_skb_irq(rcv->skb);
                rcv->skb = NULL;
        }
        snd->state = PLIP_PK_DONE;
        if (snd->skb) {
-               dev_kfree_skb(snd->skb);
+               dev_consume_skb_irq(snd->skb);
                snd->skb = NULL;
        }
        spin_unlock_irq(&nl->lock);