]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: fcoe: Simplify if-if to if-else
authorYihao Han <hanyihao@vivo.com>
Fri, 8 Apr 2022 08:12:37 +0000 (01:12 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 19 Apr 2022 02:57:35 +0000 (22:57 -0400)
Replace 'if (!is_zero_ether_addr(mac))' with 'else' for simplification and
add curly brackets according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is a
single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Link: https://lore.kernel.org/r/20220408081237.14037-1-hanyihao@vivo.com
Signed-off-by: Yihao Han <hanyihao@vivo.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fcoe/fcoe.c

index 44ca6110213caaf7222c8b69c6c3fc2a08687495..983e00135feac156a61c79d421f10d755ed98848 100644 (file)
@@ -2580,7 +2580,7 @@ static void fcoe_flogi_resp(struct fc_seq *seq, struct fc_frame *fp, void *arg)
        /* pre-FIP */
        if (is_zero_ether_addr(mac))
                fcoe_ctlr_recv_flogi(fip, lport, fp);
-       if (!is_zero_ether_addr(mac))
+       else
                fcoe_update_src_mac(lport, mac);
 done:
        fc_lport_flogi_resp(seq, fp, lport);