]> git.baikalelectronics.ru Git - kernel.git/commitdiff
sock: free skb in skb_complete_tx_timestamp on error
authorWillem de Bruijn <willemb@google.com>
Wed, 13 Dec 2017 19:41:06 +0000 (14:41 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Dec 2017 16:30:36 +0000 (11:30 -0500)
skb_complete_tx_timestamp must ingest the skb it is passed. Call
kfree_skb if the skb cannot be enqueued.

Fixes: 5b2c0c8cf9ac ("net-timestamp: no-payload only sysctl")
Fixes: 4dbb86035050 ("net: fix socket refcounting in skb_complete_tx_timestamp()")
Reported-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/skbuff.c

index 6b0ff396fa9dc58fed483597d459c66243be4cd2..a592ca025fc46bf4ff26c900d273b1ae12afa334 100644 (file)
@@ -4293,7 +4293,7 @@ void skb_complete_tx_timestamp(struct sk_buff *skb,
        struct sock *sk = skb->sk;
 
        if (!skb_may_tx_timestamp(sk, false))
-               return;
+               goto err;
 
        /* Take a reference to prevent skb_orphan() from freeing the socket,
         * but only if the socket refcount is not zero.
@@ -4302,7 +4302,11 @@ void skb_complete_tx_timestamp(struct sk_buff *skb,
                *skb_hwtstamps(skb) = *hwtstamps;
                __skb_complete_tx_timestamp(skb, sk, SCM_TSTAMP_SND, false);
                sock_put(sk);
+               return;
        }
+
+err:
+       kfree_skb(skb);
 }
 EXPORT_SYMBOL_GPL(skb_complete_tx_timestamp);