]> git.baikalelectronics.ru Git - kernel.git/commitdiff
can: gs_usb: gs_usb_get_timestamp(): fix endpoint parameter for usb_control_msg_recv()
authorMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 20 Sep 2022 09:56:57 +0000 (11:56 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 23 Sep 2022 11:55:00 +0000 (13:55 +0200)
The 2nd argument of usb_control_msg_recv() is the "endpoint",
usb_control_msg_recv() will internally convert the endpoint into a
pipe with usb_rcvctrlpipe().

In gs_usb_get_timestamp() not the endpoint "0" is passed, but the
pipe. This worked by accident as endpoint is a __u8 and the lowest 8
bits of the pipe are 0. Fix this copy/paste error by using the correct
endpoint of "0".

Fixes: c351fac8f5e8 ("can: gs_usb: add RX and TX hardware timestamp support")
Link: https://lore.kernel.org/all/20220920100416.959226-2-mkl@pengutronix.de
Cc: John Whittington <git@jbrengineering.co.uk>
Tested-by: John Whittington <git@jbrengineering.co.uk>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c

index 5e0d280b0cd3a68146a763dc11419ce25ae869e4..1430368ca32777e9a21fd5b9e4c128cc6092555b 100644 (file)
@@ -386,8 +386,7 @@ static inline int gs_usb_get_timestamp(const struct gs_can *dev,
        __le32 timestamp;
        int rc;
 
-       rc = usb_control_msg_recv(interface_to_usbdev(dev->iface),
-                                 usb_sndctrlpipe(interface_to_usbdev(dev->iface), 0),
+       rc = usb_control_msg_recv(interface_to_usbdev(dev->iface), 0,
                                  GS_USB_BREQ_TIMESTAMP,
                                  USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
                                  dev->channel, 0,