]> git.baikalelectronics.ru Git - kernel.git/commitdiff
Fix access_ok() fallout for sparc32 and powerpc
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 4 Jan 2019 17:58:25 +0000 (09:58 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 4 Jan 2019 17:58:25 +0000 (09:58 -0800)
These two architectures actually had an intentional use of the 'type'
argument to access_ok() just to avoid warnings.

I had actually noticed the powerpc one, but forgot to then fix it up.
And I missed the sparc32 case entirely.

This is hopefully all of it.

Reported-by: Mathieu Malaterre <malat@debian.org>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Fixes: 2fb4498d8456 ("Remove 'type' argument from access_ok() function")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/powerpc/include/asm/uaccess.h
arch/sparc/include/asm/uaccess_32.h

index b31bf45eebd49ddce0c6fa46da8691ffb5a70bf1..e3a731793ea23f24bbe28981f7191ed48a14f715 100644 (file)
@@ -63,7 +63,7 @@ static inline int __access_ok(unsigned long addr, unsigned long size,
 #endif
 
 #define access_ok(addr, size)          \
-       (__chk_user_ptr(addr), (void)(type),            \
+       (__chk_user_ptr(addr),          \
         __access_ok((__force unsigned long)(addr), (size), get_fs()))
 
 /*
index 69afb856e18151e1b41d45b7d6da34d0dfb8f6ed..5153798051fb2f0a3a529ec62e8f8fe9b7b7ff2e 100644 (file)
@@ -39,8 +39,7 @@
 #define __user_ok(addr, size) ({ (void)(size); (addr) < STACK_TOP; })
 #define __kernel_ok (uaccess_kernel())
 #define __access_ok(addr, size) (__user_ok((addr) & get_fs().seg, (size)))
-#define access_ok(addr, size) \
-       ({ (void)(type); __access_ok((unsigned long)(addr), size); })
+#define access_ok(addr, size) __access_ok((unsigned long)(addr), size)
 
 /*
  * The exception table consists of pairs of addresses: the first is the