]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: bsg: Drop needless assignment in scsi_bsg_sg_io_fn()
authorLukas Bulwahn <lukas.bulwahn@gmail.com>
Tue, 15 Mar 2022 05:53:25 +0000 (06:53 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 15 Mar 2022 18:05:02 +0000 (14:05 -0400)
Commit e7def244f1b8 ("scsi: core: Remove the cmd field from struct
scsi_request") refactored scsi_bsg_sg_io_fn() so that it does not allocate
directly and hence does not return -ENOMEM in its error case.  That makes a
remaining assignment of -ENOMEM to the return variable needless.

Drop this needless assignment in scsi_bsg_sg_io_fn().

No functional change. No change in resulting object code.

Link: https://lore.kernel.org/r/20220315055325.14974-1-lukas.bulwahn@gmail.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_bsg.c

index 8039c3c11a6ee9c28724b84275b977f1d9ef6b8d..96ee35256a168f3b70a4e1eeab0eb8a5cf7b0f49 100644 (file)
@@ -31,7 +31,6 @@ static int scsi_bsg_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr,
                return PTR_ERR(rq);
        rq->timeout = timeout;
 
-       ret = -ENOMEM;
        scmd = blk_mq_rq_to_pdu(rq);
        scmd->cmd_len = hdr->request_len;
        if (scmd->cmd_len > sizeof(scmd->cmnd)) {