]> git.baikalelectronics.ru Git - kernel.git/commitdiff
gpio: altera-a10sr: Trivial coding style fix
authorAxel Lin <axel.lin@ingics.com>
Wed, 23 Jan 2019 00:00:58 +0000 (08:00 +0800)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Thu, 14 Feb 2019 14:14:38 +0000 (15:14 +0100)
Change the coding style to make it does error checking first.
This also fixes checkpatch warning about line over 80 characters.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Tested by: Thor Thayer <thor.thayer@linux.intel.com>
Reviewed by: Thor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-altera-a10sr.c

index 7f9e0304b5109a8b51fc108679cc32d4d8fbb9e8..1cea4efccf7cd4eaf2fc07b5c005697590ca467c 100644 (file)
@@ -58,19 +58,20 @@ static void altr_a10sr_gpio_set(struct gpio_chip *chip, unsigned int offset,
 static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,
                                           unsigned int nr)
 {
-       if (nr >= (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT))
-               return 0;
-       return -EINVAL;
+       if (nr < (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT))
+               return -EINVAL;
+
+       return 0;
 }
 
 static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,
                                            unsigned int nr, int value)
 {
-       if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) {
-               altr_a10sr_gpio_set(gc, nr, value);
-               return 0;
-       }
-       return -EINVAL;
+       if (nr > (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT))
+               return -EINVAL;
+
+       altr_a10sr_gpio_set(gc, nr, value);
+       return 0;
 }
 
 static const struct gpio_chip altr_a10sr_gc = {