fou: avoid missing unlock in failure path

Fixes: 56463fbcbdc8 ("fou: implement FOU_CMD_GET")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
index af150b43b214123b052c43ec7e40449af3d7ecd2..34968cd5c1464bf896ba1a2130fc223c50973499 100644 (file)
--- a/net/ipv4/fou.c
+++ b/net/ipv4/fou.c
@@ -711,11 +711,10 @@ static int fou_nl_dump(struct sk_buff *skb, struct netlink_callback *cb)
                                    cb->nlh->nlmsg_seq, NLM_F_MULTI,
                                    skb, FOU_CMD_GET);
                if (ret)
-                       goto done;
+                       break;
        }
        mutex_unlock(&fn->fou_lock);
 
-done:
        cb->args[0] = idx;
        return skb->len;
 }