]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/mlx5e: Remove unlikely() from WARN*() condition
authorDenis Efremov <efremov@linux.com>
Thu, 29 Aug 2019 16:50:17 +0000 (19:50 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 31 Aug 2019 02:49:03 +0000 (19:49 -0700)
"unlikely(WARN_ON_ONCE(x))" is excessive. WARN_ON_ONCE() already uses
unlikely() internally.

Signed-off-by: Denis Efremov <efremov@linux.com>
Cc: Boris Pismenny <borisp@mellanox.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c

index 7833ddef0427897043d7a6cbaa5fc41436ff2189..e5222d17df35683432d858ee44535c24a92767ea 100644 (file)
@@ -408,7 +408,7 @@ struct sk_buff *mlx5e_ktls_handle_tx_skb(struct net_device *netdev,
                goto out;
 
        tls_ctx = tls_get_ctx(skb->sk);
-       if (unlikely(WARN_ON_ONCE(tls_ctx->netdev != netdev)))
+       if (WARN_ON_ONCE(tls_ctx->netdev != netdev))
                goto err_out;
 
        priv_tx = mlx5e_get_ktls_tx_priv_ctx(tls_ctx);