]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/exynos: Delete an error message in three functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 5 Apr 2020 12:10:09 +0000 (14:10 +0200)
committerInki Dae <inki.dae@samsung.com>
Mon, 18 May 2020 02:36:00 +0000 (11:36 +0900)
The function “platform_get_irq” can log an error already.
Thus omit redundant messages for the exception handling in the
calling functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_dsi.c
drivers/gpu/drm/exynos/exynos_drm_rotator.c
drivers/gpu/drm/exynos/exynos_drm_scaler.c

index 902938d2568f97bf070da239eecaa121b1a59d8b..958e2c6a6702c9ee199a7910303cbc111b863de3 100644 (file)
@@ -1809,10 +1809,8 @@ static int exynos_dsi_probe(struct platform_device *pdev)
        }
 
        dsi->irq = platform_get_irq(pdev, 0);
-       if (dsi->irq < 0) {
-               dev_err(dev, "failed to request dsi irq resource\n");
+       if (dsi->irq < 0)
                return dsi->irq;
-       }
 
        irq_set_status_flags(dsi->irq, IRQ_NOAUTOEN);
        ret = devm_request_threaded_irq(dev, dsi->irq, NULL,
index dafa87b82052967ca27292c261008125a8e4d58d..2d94afba031e429e351ffe1d2e7d3cf1f99295b2 100644 (file)
@@ -293,10 +293,8 @@ static int rotator_probe(struct platform_device *pdev)
                return PTR_ERR(rot->regs);
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "failed to get irq\n");
+       if (irq < 0)
                return irq;
-       }
 
        ret = devm_request_irq(dev, irq, rotator_irq_handler, 0, dev_name(dev),
                               rot);
index 93c43c8d914ee78a1b275b700c6486026958ce84..ce1857138f89301cdc1a134744aea46c91622abd 100644 (file)
@@ -502,10 +502,8 @@ static int scaler_probe(struct platform_device *pdev)
                return PTR_ERR(scaler->regs);
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "failed to get irq\n");
+       if (irq < 0)
                return irq;
-       }
 
        ret = devm_request_threaded_irq(dev, irq, NULL, scaler_irq_handler,
                                        IRQF_ONESHOT, "drm_scaler", scaler);