]> git.baikalelectronics.ru Git - kernel.git/commitdiff
dmaengine: at_hdmac: add missing kfree() call in at_dma_xlate()
authorYu Kuai <yukuai3@huawei.com>
Mon, 17 Aug 2020 11:57:28 +0000 (19:57 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 19 Aug 2020 04:28:38 +0000 (09:58 +0530)
If memory allocation for 'atslave' succeed, at_dma_xlate() doesn't have a
corresponding kfree() in exception handling. Thus add kfree() for this
function implementation.

Fixes: 3b0bd9094996 ("at_hdmac: move to generic DMA binding")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20200817115728.1706719-4-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_hdmac.c

index bf874367097cc17684aa8bc3837f2927d8da22a8..a2cf25c6e3b35603d14a1c7545e137c2a3a3072f 100644 (file)
@@ -1691,6 +1691,7 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
        chan = dma_request_channel(mask, at_dma_filter, atslave);
        if (!chan) {
                put_device(&dmac_pdev->dev);
+               kfree(atslave);
                return NULL;
        }