net: pcs-rzn1-miic: fix return value check in miic_probe()

On failure, devm_platform_ioremap_resource() returns a ERR_PTR() value
and not NULL. Fix return value checking by using IS_ERR() and return
PTR_ERR() as error value.

Fixes: d2909d765ef7 ("net: pcs: add Renesas MII converter driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Clément Léger <clement.leger@bootlin.com>
Link: https://lore.kernel.org/r/20220628131259.3109124-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index 8f5e910f443d6192f6ba37969ac263a0ecd2f41f..d896961e48cc203a05c4705f1010402fd590d3f6 100644 (file)
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -461,8 +461,8 @@ static int miic_probe(struct platform_device *pdev)
        spin_lock_init(&miic->lock);
        miic->dev = dev;
        miic->base = devm_platform_ioremap_resource(pdev, 0);
-       if (!miic->base)
-               return -EINVAL;
+       if (IS_ERR(miic->base))
+               return PTR_ERR(miic->base);
 
        ret = devm_pm_runtime_enable(dev);
        if (ret < 0)