]> git.baikalelectronics.ru Git - kernel.git/commitdiff
tty/vt: consolemap: saner variable names in con_copy_unimap()
authorJiri Slaby <jslaby@suse.cz>
Tue, 7 Jun 2022 10:49:37 +0000 (12:49 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jun 2022 11:37:03 +0000 (13:37 +0200)
The function uses too vague variable names like i, j, k for iterators, p,
q, p1, p2 for pointers etc.

Rename all these, so that it is clear what is going on:
- dict: for dictionaries.
- d, r, g: for dir, row, glyph iterators -- these are unsigned now.
- dir, row: for directory and row pointers.
- glyph: for the glyph.
- and so on...

This is a lot of shuffling, but the result pays off, IMO.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220607104946.18710-27-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/consolemap.c

index 255d4e92a9d01e7edde960d325191781979b9e3b..dcbeb38a3a0ae9d38569f12c3878872b1974cba1 100644 (file)
@@ -750,16 +750,16 @@ EXPORT_SYMBOL(con_set_default_unimap);
  */
 int con_copy_unimap(struct vc_data *dst_vc, struct vc_data *src_vc)
 {
-       struct uni_pagedict *q;
+       struct uni_pagedict *src;
 
        if (!*src_vc->vc_uni_pagedir_loc)
                return -EINVAL;
        if (*dst_vc->vc_uni_pagedir_loc == *src_vc->vc_uni_pagedir_loc)
                return 0;
        con_free_unimap(dst_vc);
-       q = *src_vc->vc_uni_pagedir_loc;
-       q->refcount++;
-       *dst_vc->vc_uni_pagedir_loc = q;
+       src = *src_vc->vc_uni_pagedir_loc;
+       src->refcount++;
+       *dst_vc->vc_uni_pagedir_loc = src;
        return 0;
 }
 EXPORT_SYMBOL(con_copy_unimap);