]> git.baikalelectronics.ru Git - kernel.git/commitdiff
gpu: ipu-v3: common: Add of_node_put() for reference returned by of_graph_get_port_by...
authorLiang He <windhl@126.com>
Wed, 20 Jul 2022 15:22:27 +0000 (23:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:43:44 +0000 (16:43 +0100)
[ Upstream commit 9afdf98cfdfa2ba8ec068cf08c5fcdc1ed8daf3f ]

In ipu_add_client_devices(), we need to call of_node_put() for
reference returned by of_graph_get_port_by_id() in fail path.

Fixes: 8007ab5a8351 ("gpu: ipu-v3: Do not bail out on missing optional port nodes")
Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20220720152227.1288413-1-windhl@126.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220720152227.1288413-1-windhl@126.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/ipu-v3/ipu-common.c

index b3dae9ec1a38bf18c16a480ee5ded8cb16d0dfa1..528812bf84da727d25ac601a16a3f7997e51dc91 100644 (file)
@@ -1235,6 +1235,7 @@ static int ipu_add_client_devices(struct ipu_soc *ipu, unsigned long ipu_base)
                pdev = platform_device_alloc(reg->name, id++);
                if (!pdev) {
                        ret = -ENOMEM;
+                       of_node_put(of_node);
                        goto err_register;
                }