]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/radeon: fix scatter-gather mapping with user pages
authorShane Francis <bigbeeshane@gmail.com>
Wed, 25 Mar 2020 09:07:41 +0000 (09:07 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 25 Mar 2020 16:10:55 +0000 (12:10 -0400)
Calls to dma_map_sg may return less segments / entries than requested
if they fall on page bounderies. The old implementation did not
support this use case.

Fixes: 4cfcb5cbd10a ("iommu/amd: Convert AMD iommu driver to the dma-iommu api")
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=206461
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=206895
Bug: https://gitlab.freedesktop.org/drm/amd/issues/1056
Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200325090741.21957-4-bigbeeshane@gmail.com
Cc: stable@vger.kernel.org
drivers/gpu/drm/radeon/radeon_ttm.c

index 3b92311d30b98476e127130c05bc0b122739a668..b3380ffab4c2072d191f58fbbdf01ee019eb9d26 100644 (file)
@@ -528,7 +528,7 @@ static int radeon_ttm_tt_pin_userptr(struct ttm_tt *ttm)
 
        r = -ENOMEM;
        nents = dma_map_sg(rdev->dev, ttm->sg->sgl, ttm->sg->nents, direction);
-       if (nents != ttm->sg->nents)
+       if (nents == 0)
                goto release_sg;
 
        drm_prime_sg_to_page_addr_arrays(ttm->sg, ttm->pages,