]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: hns3: disable phy loopback setting in hclge_mac_start_phy
authorYufeng Mo <moyufeng@huawei.com>
Fri, 30 Apr 2021 09:06:22 +0000 (17:06 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Apr 2021 21:49:33 +0000 (14:49 -0700)
If selftest and reset are performed at the same time, the phy
loopback setting may be still in enable state after the reset,
and device cannot link up. So fix this issue by disabling phy
loopback before phy_start().

Fixes: d6a397b7fa3e ("net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC")
Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c

index 08e88d9422cde3dfe145fdd9813a8b513e730b20..1231c34f0949459d9f99be356fb4a41bf957ba46 100644 (file)
@@ -255,6 +255,8 @@ void hclge_mac_start_phy(struct hclge_dev *hdev)
        if (!phydev)
                return;
 
+       phy_loopback(phydev, false);
+
        phy_start(phydev);
 }