]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/i915: move gmbus restore to i915_restore_display
authorJani Nikula <jani.nikula@intel.com>
Thu, 10 Sep 2020 09:52:27 +0000 (12:52 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 11 Sep 2020 10:50:37 +0000 (13:50 +0300)
Logically part of the display restore.

Note: This has been in place since the introduction of gmbus
support. The gmbus code also does the resets before transfers. Is this
really needed, or a historical accident?

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200910095227.9466-3-jani.nikula@intel.com
drivers/gpu/drm/i915/i915_suspend.c

index 4a93247942b71a46068e1aa4ec0287e902153f35..09026c4db7d059bca9bc52e3a453d960e340adc6 100644 (file)
@@ -69,6 +69,8 @@ static void i915_restore_display(struct drm_i915_private *dev_priv)
                I915_WRITE(FBC_CONTROL, dev_priv->regfile.saveFBC_CONTROL);
 
        intel_vga_redisable(dev_priv);
+
+       intel_gmbus_reset(dev_priv);
 }
 
 int i915_save_state(struct drm_i915_private *dev_priv)
@@ -141,7 +143,5 @@ int i915_restore_state(struct drm_i915_private *dev_priv)
                        I915_WRITE(SWF3(i), dev_priv->regfile.saveSWF3[i]);
        }
 
-       intel_gmbus_reset(dev_priv);
-
        return 0;
 }