]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dpaa2: Use napi_alloc_frag_align() to avoid the memory waste
authorKevin Hao <haokexin@gmail.com>
Thu, 4 Feb 2021 10:56:38 +0000 (18:56 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 6 Feb 2021 19:57:29 +0000 (11:57 -0800)
The napi_alloc_frag_align() will guarantee that a correctly align
buffer address is returned. So use this function to simplify the buffer
alloc and avoid the unnecessary memory waste.

Signed-off-by: Kevin Hao <haokexin@gmail.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

index c5ceebca8caeb9f1508b4acda4740b535d818a0f..19f74d4cbb4ebe4282be3b77219c135f86cec3f0 100644 (file)
@@ -764,12 +764,11 @@ static int dpaa2_eth_build_sg_fd(struct dpaa2_eth_priv *priv,
        /* Prepare the HW SGT structure */
        sgt_buf_size = priv->tx_data_offset +
                       sizeof(struct dpaa2_sg_entry) *  num_dma_bufs;
-       sgt_buf = napi_alloc_frag(sgt_buf_size + DPAA2_ETH_TX_BUF_ALIGN);
+       sgt_buf = napi_alloc_frag_align(sgt_buf_size, DPAA2_ETH_TX_BUF_ALIGN);
        if (unlikely(!sgt_buf)) {
                err = -ENOMEM;
                goto sgt_buf_alloc_failed;
        }
-       sgt_buf = PTR_ALIGN(sgt_buf, DPAA2_ETH_TX_BUF_ALIGN);
        memset(sgt_buf, 0, sgt_buf_size);
 
        sgt = (struct dpaa2_sg_entry *)(sgt_buf + priv->tx_data_offset);