]> git.baikalelectronics.ru Git - kernel.git/commitdiff
usb:oxu210hp-hcd: Use platform_get_irq() to get the interrupt
authorMinghao Chi <chi.minghao@zte.com.cn>
Wed, 9 Mar 2022 05:36:11 +0000 (05:36 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Apr 2022 17:02:56 +0000 (19:02 +0200)
It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ)
for requesting IRQ's resources any more, as they can be not ready yet in
case of DT-booting.

platform_get_irq() instead is a recommended way for getting IRQ even if
it was not retrieved earlier.

It also makes code simpler because we're getting "int" value right away
and no conversion from resource to int is required.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220309053611.2081191-1-chi.minghao@zte.com.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/oxu210hp-hcd.c

index b741670525e34501a98340e0c85e791cccafe707..ddc155850bfcd9f7255f0afaaf3cd1fce980cb42 100644 (file)
@@ -4223,13 +4223,9 @@ static int oxu_drv_probe(struct platform_device *pdev)
        /*
         * Get the platform resources
         */
-       res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (!res) {
-               dev_err(&pdev->dev,
-                       "no IRQ! Check %s setup!\n", dev_name(&pdev->dev));
-               return -ENODEV;
-       }
-       irq = res->start;
+       irq = platform_get_irq(pdev, 0);
+       if (irq < 0)
+               return irq;
        dev_dbg(&pdev->dev, "IRQ resource %d\n", irq);
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);