]> git.baikalelectronics.ru Git - kernel.git/commitdiff
block: Fix the bio.bi_opf comment
authorBart Van Assche <bvanassche@acm.org>
Wed, 11 May 2022 23:51:52 +0000 (16:51 -0700)
committerJens Axboe <axboe@kernel.dk>
Thu, 12 May 2022 12:33:26 +0000 (06:33 -0600)
Commit 43a94d680d3e modified the Linux kernel such that the bottom bits
of the bi_opf member contain the operation instead of the topmost bits.
That commit did not update the comment next to bi_opf. Hence this patch.

From commit 43a94d680d3e:
-#define bio_op(bio)    ((bio)->bi_opf >> BIO_OP_SHIFT)
+#define bio_op(bio)    ((bio)->bi_opf & REQ_OP_MASK)

Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Fixes: 43a94d680d3e ("block: better op and flags encoding")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220511235152.1082246-1-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/blk_types.h

index 30f9a5391fd5e3751762f0b98dccdd9010c2726c..40e8154006110a5f27a116371cae6e18c7f86bc9 100644 (file)
@@ -246,9 +246,8 @@ typedef unsigned int blk_qc_t;
 struct bio {
        struct bio              *bi_next;       /* request queue link */
        struct block_device     *bi_bdev;
-       unsigned int            bi_opf;         /* bottom bits req flags,
-                                                * top bits REQ_OP. Use
-                                                * accessors.
+       unsigned int            bi_opf;         /* bottom bits REQ_OP, top bits
+                                                * req_flags.
                                                 */
        unsigned short          bi_flags;       /* BIO_* below */
        unsigned short          bi_ioprio;