]> git.baikalelectronics.ru Git - kernel.git/commitdiff
of: overlay: kmemleak in dup_and_fixup_symbol_prop()
authorFrank Rowand <frank.rowand@sony.com>
Thu, 16 Apr 2020 21:42:49 +0000 (16:42 -0500)
committerRob Herring <robh@kernel.org>
Fri, 17 Apr 2020 13:31:34 +0000 (08:31 -0500)
kmemleak reports several memory leaks from devicetree unittest.
This is the fix for problem 4 of 5.

target_path was not freed in the non-error path.

Fixes: e0a58f3e08d4 ("of: overlay: remove a dependency on device node full_name")
Reported-by: Erhard F. <erhard_f@mailbox.org>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/overlay.c

index c9219fddf44bea12fe7f8e14dfc3b224631c7bbb..50bbe0edf538022c2f9f2f13546499fe4addf643 100644 (file)
@@ -261,6 +261,8 @@ static struct property *dup_and_fixup_symbol_prop(
 
        of_property_set_flag(new_prop, OF_DYNAMIC);
 
+       kfree(target_path);
+
        return new_prop;
 
 err_free_new_prop: