refactor(morello): remove duplication of platform information struct

morello_plat_info is defined identically in multiple files, definition
is moved to a header file to avoid duplication.

Signed-off-by: Werner Lewis <werner.lewis@arm.com>
Change-Id: I607354902c55f5c31f0732de9db60604b82aef97

diff --git a/plat/arm/board/morello/morello_bl2_setup.c b/plat/arm/board/morello/morello_bl2_setup.c
index ec87a8e3e60c0a3dd063305028a359801ae61ae3..39020e236a32b1ce4eb414472dba01b12a2c4850 100644 (file)
--- a/plat/arm/board/morello/morello_bl2_setup.c
+++ b/plat/arm/board/morello/morello_bl2_setup.c
@@ -13,42 +13,6 @@
 #include "morello_def.h"
 #include <platform_def.h>
 
-#ifdef TARGET_PLATFORM_FVP
-/*
- * Platform information structure stored in SDS.
- * This structure holds information about platform's DDR
- * size
- *     - Local DDR size in bytes, DDR memory in main board
- */
-struct morello_plat_info {
-       uint64_t local_ddr_size;
-} __packed;
-#else
-/*
- * Platform information structure stored in SDS.
- * This structure holds information about platform's DDR
- * size which is an information about multichip setup
- *     - Local DDR size in bytes, DDR memory in main board
- *     - Remote DDR size in bytes, DDR memory in remote board
- *     - remote_chip_count
- *     - multichip mode
- *     - scc configuration
- *     - silicon revision
- */
-struct morello_plat_info {
-       uint64_t local_ddr_size;
-       uint64_t remote_ddr_size;
-       uint8_t remote_chip_count;
-       bool multichip_mode;
-       uint32_t scc_config;
-       uint32_t silicon_revision;
-} __packed;
-#endif
-
-/* Compile time assertion to ensure the size of structure is 18 bytes */
-CASSERT(sizeof(struct morello_plat_info) == MORELLO_SDS_PLATFORM_INFO_SIZE,
-               assert_invalid_plat_info_size);
-
 #ifdef TARGET_PLATFORM_SOC
 /*
  * Morello platform supports RDIMMs with ECC capability. To use the ECC

diff --git a/plat/arm/board/morello/morello_bl31_setup.c b/plat/arm/board/morello/morello_bl31_setup.c
index 8f0159239900c147bbc9127a0cab07a1a2737fd1..cef42f46cbc3f3e87cc8987a16a737fb8604bdc2 100644 (file)
--- a/plat/arm/board/morello/morello_bl31_setup.c
+++ b/plat/arm/board/morello/morello_bl31_setup.c
@@ -14,44 +14,10 @@
 #include "morello_def.h"
 #include <platform_def.h>
 
-#ifdef TARGET_PLATFORM_FVP
-/*
- * Platform information structure stored in SDS.
- * This structure holds information about platform's DDR
- * size
- *     - Local DDR size in bytes, DDR memory in main board
- */
-struct morello_plat_info {
-       uint64_t local_ddr_size;
-} __packed;
-#else
-/*
- * Platform information structure stored in SDS.
- * This structure holds information about platform's DDR
- * size which is an information about multichip setup
- *     - Local DDR size in bytes, DDR memory in main board
- *     - Remote DDR size in bytes, DDR memory in remote board
- *     - remote_chip_count
- *     - multichip mode
- *     - scc configuration
- *     - silicon revision
- */
-struct morello_plat_info {
-       uint64_t local_ddr_size;
-       uint64_t remote_ddr_size;
-       uint8_t remote_chip_count;
-       bool multichip_mode;
-       uint32_t scc_config;
-       uint32_t silicon_revision;
-} __packed;
-
+#ifdef TARGET_PLATFORM_SOC
 struct morello_plat_info plat_info;
 #endif
 
-/* Compile time assertion to ensure the size of structure is of the required bytes */
-CASSERT(sizeof(struct morello_plat_info) == MORELLO_SDS_PLATFORM_INFO_SIZE,
-               assert_invalid_plat_info_size);
-
 static scmi_channel_plat_info_t morello_scmi_plat_info = {
        .scmi_mbx_mem = MORELLO_SCMI_PAYLOAD_BASE,
        .db_reg_addr = PLAT_CSS_MHU_BASE + CSS_SCMI_MHU_DB_REG_OFF,

diff --git a/plat/arm/board/morello/morello_def.h b/plat/arm/board/morello/morello_def.h
index 2898774c54620b61f8d2e868a86336acefb3e45c..e42a03c36b447d8ac6bbacd316cfc3eee3b53ab1 100644 (file)
--- a/plat/arm/board/morello/morello_def.h
+++ b/plat/arm/board/morello/morello_def.h
@@ -89,4 +89,41 @@
 #define MORELLO_DMC_MEMC_CMD_CONFIG            U(0)
 #define MORELLO_DMC_MEMC_CMD_READY             U(3)
 
+/* SDS Platform information struct definition */
+#ifdef TARGET_PLATFORM_FVP
+/*
+ * Platform information structure stored in SDS.
+ * This structure holds information about platform's DDR
+ * size
+ *     - Local DDR size in bytes, DDR memory in main board
+ */
+struct morello_plat_info {
+       uint64_t local_ddr_size;
+} __packed;
+#else
+/*
+ * Platform information structure stored in SDS.
+ * This structure holds information about platform's DDR
+ * size which is an information about multichip setup
+ *     - Local DDR size in bytes, DDR memory in main board
+ *     - Remote DDR size in bytes, DDR memory in remote board
+ *     - remote_chip_count
+ *     - multichip mode
+ *     - scc configuration
+ *     - silicon revision
+ */
+struct morello_plat_info {
+       uint64_t local_ddr_size;
+       uint64_t remote_ddr_size;
+       uint8_t remote_chip_count;
+       bool multichip_mode;
+       uint32_t scc_config;
+       uint32_t silicon_revision;
+} __packed;
+#endif
+
+/* Compile time assertion to ensure the size of structure is of the required bytes */
+CASSERT(sizeof(struct morello_plat_info) == MORELLO_SDS_PLATFORM_INFO_SIZE,
+               assert_invalid_plat_info_size);
+
 #endif /* MORELLO_DEF_H */

diff --git a/plat/arm/board/morello/morello_image_load.c b/plat/arm/board/morello/morello_image_load.c
index 5fc87a05d45747785628cbdabe7092406df529c8..b5d9bd54e53d9c0136fbf9a7175d63fd0ebfb0cd 100644 (file)
--- a/plat/arm/board/morello/morello_image_load.c
+++ b/plat/arm/board/morello/morello_image_load.c
@@ -14,38 +14,6 @@
 #include <plat/arm/common/plat_arm.h>
 #include <plat/common/platform.h>
 
-#ifdef TARGET_PLATFORM_FVP
-/*
- * Platform information structure stored in SDS.
- * This structure holds information about platform's DDR
- * size which is an information about multichip setup
- *     - Local DDR size in bytes, DDR memory in main board
- */
-struct morello_plat_info {
-       uint64_t local_ddr_size;
-} __packed;
-#else
-/*
- * Platform information structure stored in SDS.
- * This structure holds information about platform's DDR
- * size which is an information about multichip setup
- *     - Local DDR size in bytes, DDR memory in main board
- *     - Remote DDR size in bytes, DDR memory in remote board
- *     - remote_chip_count
- *     - multichip mode
- *     - scc configuration
- *     - silicon revision
- */
-struct morello_plat_info {
-       uint64_t local_ddr_size;
-       uint64_t remote_ddr_size;
-       uint8_t remote_chip_count;
-       bool multichip_mode;
-       uint32_t scc_config;
-       uint32_t silicon_revision;
-} __packed;
-#endif
-
 /* In client mode, a part of the DDR memory is reserved for Tag bits.
  * Calculate the usable memory size after subtracting the Tag memory.
  */