]> git.baikalelectronics.ru Git - kernel.git/commitdiff
nfc: s3fwrn5: fix undefined parameter values in dev_err()
authorTang Bin <tangbin@cmss.chinamobile.com>
Wed, 28 Jul 2021 01:49:25 +0000 (09:49 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Jul 2021 08:23:59 +0000 (09:23 +0100)
In the function s3fwrn5_fw_download(), the 'ret' is not assigned,
so the correct value should be given in dev_err function.

Fixes: a0302ff5906a ("nfc: s3fwrn5: remove unnecessary label")
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/nfc/s3fwrn5/firmware.c

index 1340fab9565e2340cc1deda82bba192597f02739..e3e72b8a29e3f3e31fb468371f27319ed17f28ce 100644 (file)
@@ -423,7 +423,7 @@ int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info)
        if (IS_ERR(tfm)) {
                ret = PTR_ERR(tfm);
                dev_err(&fw_info->ndev->nfc_dev->dev,
-                       "Cannot allocate shash (code=%ld)\n", PTR_ERR(tfm));
+                       "Cannot allocate shash (code=%pe)\n", tfm);
                goto out;
        }