]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ASoC: audio-graph-card: Add of_node_put() in fail path
authorLiang He <windhl@126.com>
Thu, 21 Jul 2022 14:43:08 +0000 (22:43 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:11 +0000 (14:24 +0200)
[ Upstream commit 86ae8e1dd7d84136d089757599eb64f66df4b5cc ]

In asoc_simple_parse_dai(), we should call of_node_put() for the
reference returned by of_graph_get_port_parent() in fail path.

Fixes: 8b5df68d7fd8 ("ASoC: simple-card-utils: add asoc_simple_card_parse_dai()")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220721144308.1301587-1-windhl@126.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/generic/audio-graph-card.c

index 546f6fd0609e131e4da9210f0e78d265c2ed6e45..28cbcdb56857f5e5d3d191e27e75d3c2a7609ce1 100644 (file)
@@ -158,8 +158,10 @@ static int asoc_simple_parse_dai(struct device_node *ep,
         *    if he unbinded CPU or Codec.
         */
        ret = snd_soc_get_dai_name(&args, &dlc->dai_name);
-       if (ret < 0)
+       if (ret < 0) {
+               of_node_put(node);
                return ret;
+       }
 
        dlc->of_node = node;