projects
/
kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
65acd82
)
spi: cadence-quadspi: Simplify with dev_err_probe()
author
Krzysztof Kozlowski
<krzk@kernel.org>
Tue, 1 Sep 2020 15:27:07 +0000
(17:27 +0200)
committer
Mark Brown
<broonie@kernel.org>
Tue, 8 Sep 2020 17:19:26 +0000
(18:19 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link:
https://lore.kernel.org/r/20200901152713.18629-5-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-cadence-quadspi.c
b/drivers/spi/spi-cadence-quadspi.c
index 1c1a9d17eec0d4af3bcd11132cfb7a87435fccfd..0e5e45951eb06feac2edb85fa659961d06cabb93 100644
(file)
--- a/
drivers/spi/spi-cadence-quadspi.c
+++ b/
drivers/spi/spi-cadence-quadspi.c
@@
-1117,11
+1117,8
@@
static int cqspi_request_mmap_dma(struct cqspi_st *cqspi)
cqspi->rx_chan = dma_request_chan_by_mask(&mask);
if (IS_ERR(cqspi->rx_chan)) {
int ret = PTR_ERR(cqspi->rx_chan);
-
- if (ret != -EPROBE_DEFER)
- dev_err(&cqspi->pdev->dev, "No Rx DMA available\n");
cqspi->rx_chan = NULL;
- return
ret
;
+ return
dev_err_probe(&cqspi->pdev->dev, ret, "No Rx DMA available\n")
;
}
init_completion(&cqspi->rx_dma_complete);