]> git.baikalelectronics.ru Git - kernel.git/commitdiff
mtd: rawnand: omap2: Actually prevent invalid configuration and build error
authorRoger Quadros <rogerq@kernel.org>
Sat, 19 Feb 2022 19:36:00 +0000 (21:36 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 7 Mar 2022 16:46:54 +0000 (17:46 +0100)
The root of the problem is that we are selecting symbols that have
dependencies. This can cause random configurations that can fail.
The cleanest solution is to avoid using select.

This driver uses interfaces from the OMAP_GPMC driver so we have to
depend on it instead.

Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")
Signed-off-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/linux-mtd/20220219193600.24892-1-rogerq@kernel.org
drivers/mtd/nand/raw/Kconfig

index d986ab4e4c35fd366650e8f43fbaf4ff79372893..820e5dc3bc9b4a8a9ec1741af2d81fc44a710bc7 100644 (file)
@@ -42,8 +42,7 @@ config MTD_NAND_OMAP2
        tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller"
        depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
        depends on HAS_IOMEM
-       select MEMORY
-       select OMAP_GPMC
+       depends on OMAP_GPMC
        help
          Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4
          and Keystone platforms.