]> git.baikalelectronics.ru Git - kernel.git/commitdiff
devlink: Remove misleading internal_flags from health reporter dump
authorLeon Romanovsky <leonro@nvidia.com>
Sun, 28 Nov 2021 12:14:46 +0000 (14:14 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Nov 2021 13:04:26 +0000 (13:04 +0000)
DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET command doesn't have .doit callback
and has no use in internal_flags at all. Remove this misleading assignment.

Fixes: 862f45f6e290 ("devlink: Hang reporter's dump method on a dumpit cb")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/devlink.c

index d144a62cbf739de6fb5585a5a40d941d37ff42eb..fd21022145a309c31ba3201fcb317f92b164a1c0 100644 (file)
@@ -8845,8 +8845,6 @@ static const struct genl_small_ops devlink_nl_ops[] = {
                            GENL_DONT_VALIDATE_DUMP_STRICT,
                .dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit,
                .flags = GENL_ADMIN_PERM,
-               .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT |
-                                 DEVLINK_NL_FLAG_NO_LOCK,
        },
        {
                .cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR,