]> git.baikalelectronics.ru Git - kernel.git/commitdiff
sparc: fix mis-use of __kernel_{uid,gid}_t in uapi/asm/stat.h
authorMasahiro Yamada <masahiroy@kernel.org>
Wed, 1 Jun 2022 18:19:41 +0000 (03:19 +0900)
committerArnd Bergmann <arnd@arndb.de>
Thu, 2 Jun 2022 15:38:15 +0000 (17:38 +0200)
Commit 31a088b664d6 ("sparc: add asm/stat.h to UAPI compile-test
coverage") converted as follows:

  uid_t  -->  __kernel_uid_t
  gid_t  -->  __kernel_gid_t

It changed the field widths of struct stat because Sparc uses 16-bits for
___kernel_{uid,gid}_t as in arch/sparc/include/uapi/asm/posix_types.h.

The safe replacements across all architectures are:

  uid_t  -->  __kernel_uid32_t
  gid_t  -->  __kernel_gid32_t

as defined in include/linux/types.h.

A similar issue was reported for the android binder. [1]

[1]: https://lore.kernel.org/all/20220601010017.2639048-1-cmllamas@google.com/

Fixes: 31a088b664d6 ("sparc: add asm/stat.h to UAPI compile-test coverage")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/sparc/include/uapi/asm/stat.h

index e03d6f8ec301f49e41a6673785ce5c68d6590ea3..47f54133a1417433a97cf9ed90e23f64ce10827b 100644 (file)
@@ -11,8 +11,8 @@ struct stat {
        __kernel_ino_t st_ino;
        __kernel_mode_t st_mode;
        short   st_nlink;
-       __kernel_uid_t st_uid;
-       __kernel_gid_t st_gid;
+       __kernel_uid32_t st_uid;
+       __kernel_gid32_t st_gid;
        unsigned int st_rdev;
        long    st_size;
        long    st_atime;