iommu/arm-smmu: qcom_iommu: Add of_node_put() when breaking out of loop

[ Upstream commit a68a31375a56a0be96d8a55e850787eafac1279f ]

In qcom_iommu_has_secure_context(), we should call of_node_put()
for the reference 'child' when breaking out of for_each_child_of_node()
which will automatically increase and decrease the refcount.

Fixes: 9bb530110d1c ("iommu/qcom: Initialize secure page table")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220719124955.1242171-1-windhl@126.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
index b91874cb6cf335e9a877b2b49091c4a717fb6b0e..a47cb654b7048ea3a68a98ea509123e65e334be3 100644 (file)
--- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
+++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
@@ -748,9 +748,12 @@ static bool qcom_iommu_has_secure_context(struct qcom_iommu_dev *qcom_iommu)
 {
        struct device_node *child;
 
-       for_each_child_of_node(qcom_iommu->dev->of_node, child)
-               if (of_device_is_compatible(child, "qcom,msm-iommu-v1-sec"))
+       for_each_child_of_node(qcom_iommu->dev->of_node, child) {
+               if (of_device_is_compatible(child, "qcom,msm-iommu-v1-sec")) {
+                       of_node_put(child);
                        return true;
+               }
+       }
 
        return false;
 }