]> git.baikalelectronics.ru Git - uboot.git/commitdiff
firmware: ti_sci: Add support for device control
authorAndreas Dannenberg <dannenberg@ti.com>
Mon, 27 Aug 2018 10:27:34 +0000 (15:57 +0530)
committerTom Rini <trini@konsulko.com>
Tue, 11 Sep 2018 12:32:55 +0000 (08:32 -0400)
TI-SCI message protocol provides support for management of various
hardware entitites within the SoC. Introduce the fundamental
device management capability support to the driver protocol
as part of this change.

Reviewed-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
drivers/firmware/ti_sci.c
drivers/firmware/ti_sci.h
include/linux/soc/ti/ti_sci_protocol.h

index ac61ce514725c381238ca5e8e95e7d0186e9707f..4d87cea7aa158bde4c6894420dc57449ad3b1cdd 100644 (file)
@@ -396,6 +396,384 @@ static int ti_sci_cmd_set_board_config_pm(const struct ti_sci_handle *handle,
                                              addr, size);
 }
 
+/**
+ * ti_sci_set_device_state() - Set device state helper
+ * @handle:    pointer to TI SCI handle
+ * @id:                Device identifier
+ * @flags:     flags to setup for the device
+ * @state:     State to move the device to
+ *
+ * Return: 0 if all went well, else returns appropriate error value.
+ */
+static int ti_sci_set_device_state(const struct ti_sci_handle *handle,
+                                  u32 id, u32 flags, u8 state)
+{
+       struct ti_sci_msg_req_set_device_state req;
+       struct ti_sci_msg_hdr *resp;
+       struct ti_sci_info *info;
+       struct ti_sci_xfer *xfer;
+       int ret = 0;
+
+       if (IS_ERR(handle))
+               return PTR_ERR(handle);
+       if (!handle)
+               return -EINVAL;
+
+       info = handle_to_ti_sci_info(handle);
+
+       xfer = ti_sci_setup_one_xfer(info, TI_SCI_MSG_SET_DEVICE_STATE,
+                                    flags | TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
+                                    (u32 *)&req, sizeof(req), sizeof(*resp));
+       if (IS_ERR(xfer)) {
+               ret = PTR_ERR(xfer);
+               dev_err(info->dev, "Message alloc failed(%d)\n", ret);
+               return ret;
+       }
+       req.id = id;
+       req.state = state;
+
+       ret = ti_sci_do_xfer(info, xfer);
+       if (ret) {
+               dev_err(info->dev, "Mbox send fail %d\n", ret);
+               return ret;
+       }
+
+       resp = (struct ti_sci_msg_hdr *)xfer->tx_message.buf;
+
+       if (!ti_sci_is_response_ack(resp))
+               return -ENODEV;
+
+       return ret;
+}
+
+/**
+ * ti_sci_get_device_state() - Get device state helper
+ * @handle:    Handle to the device
+ * @id:                Device Identifier
+ * @clcnt:     Pointer to Context Loss Count
+ * @resets:    pointer to resets
+ * @p_state:   pointer to p_state
+ * @c_state:   pointer to c_state
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_get_device_state(const struct ti_sci_handle *handle,
+                                  u32 id,  u32 *clcnt,  u32 *resets,
+                                  u8 *p_state,  u8 *c_state)
+{
+       struct ti_sci_msg_resp_get_device_state *resp;
+       struct ti_sci_msg_req_get_device_state req;
+       struct ti_sci_info *info;
+       struct ti_sci_xfer *xfer;
+       int ret = 0;
+
+       if (IS_ERR(handle))
+               return PTR_ERR(handle);
+       if (!handle)
+               return -EINVAL;
+
+       if (!clcnt && !resets && !p_state && !c_state)
+               return -EINVAL;
+
+       info = handle_to_ti_sci_info(handle);
+
+       /* Response is expected, so need of any flags */
+       xfer = ti_sci_setup_one_xfer(info, TI_SCI_MSG_GET_DEVICE_STATE, 0,
+                                    (u32 *)&req, sizeof(req), sizeof(*resp));
+       if (IS_ERR(xfer)) {
+               ret = PTR_ERR(xfer);
+               dev_err(info->dev, "Message alloc failed(%d)\n", ret);
+               return ret;
+       }
+       req.id = id;
+
+       ret = ti_sci_do_xfer(info, xfer);
+       if (ret) {
+               dev_err(dev, "Mbox send fail %d\n", ret);
+               return ret;
+       }
+
+       resp = (struct ti_sci_msg_resp_get_device_state *)xfer->tx_message.buf;
+       if (!ti_sci_is_response_ack(resp))
+               return -ENODEV;
+
+       if (clcnt)
+               *clcnt = resp->context_loss_count;
+       if (resets)
+               *resets = resp->resets;
+       if (p_state)
+               *p_state = resp->programmed_state;
+       if (c_state)
+               *c_state = resp->current_state;
+
+       return ret;
+}
+
+/**
+ * ti_sci_cmd_get_device() - command to request for device managed by TISCI
+ * @handle:    Pointer to TISCI handle as retrieved by *ti_sci_get_handle
+ * @id:                Device Identifier
+ *
+ * Request for the device - NOTE: the client MUST maintain integrity of
+ * usage count by balancing get_device with put_device. No refcounting is
+ * managed by driver for that purpose.
+ *
+ * NOTE: The request is for exclusive access for the processor.
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_get_device(const struct ti_sci_handle *handle, u32 id)
+{
+       return ti_sci_set_device_state(handle, id,
+                                      MSG_FLAG_DEVICE_EXCLUSIVE,
+                                      MSG_DEVICE_SW_STATE_ON);
+}
+
+/**
+ * ti_sci_cmd_idle_device() - Command to idle a device managed by TISCI
+ * @handle:    Pointer to TISCI handle as retrieved by *ti_sci_get_handle
+ * @id:                Device Identifier
+ *
+ * Request for the device - NOTE: the client MUST maintain integrity of
+ * usage count by balancing get_device with put_device. No refcounting is
+ * managed by driver for that purpose.
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_idle_device(const struct ti_sci_handle *handle, u32 id)
+{
+       return ti_sci_set_device_state(handle, id,
+                                      MSG_FLAG_DEVICE_EXCLUSIVE,
+                                      MSG_DEVICE_SW_STATE_RETENTION);
+}
+
+/**
+ * ti_sci_cmd_put_device() - command to release a device managed by TISCI
+ * @handle:    Pointer to TISCI handle as retrieved by *ti_sci_get_handle
+ * @id:                Device Identifier
+ *
+ * Request for the device - NOTE: the client MUST maintain integrity of
+ * usage count by balancing get_device with put_device. No refcounting is
+ * managed by driver for that purpose.
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_put_device(const struct ti_sci_handle *handle, u32 id)
+{
+       return ti_sci_set_device_state(handle, id,
+                                      0, MSG_DEVICE_SW_STATE_AUTO_OFF);
+}
+
+/**
+ * ti_sci_cmd_dev_is_valid() - Is the device valid
+ * @handle:    Pointer to TISCI handle as retrieved by *ti_sci_get_handle
+ * @id:                Device Identifier
+ *
+ * Return: 0 if all went fine and the device ID is valid, else return
+ * appropriate error.
+ */
+static int ti_sci_cmd_dev_is_valid(const struct ti_sci_handle *handle, u32 id)
+{
+       u8 unused;
+
+       /* check the device state which will also tell us if the ID is valid */
+       return ti_sci_get_device_state(handle, id, NULL, NULL, NULL, &unused);
+}
+
+/**
+ * ti_sci_cmd_dev_get_clcnt() - Get context loss counter
+ * @handle:    Pointer to TISCI handle
+ * @id:                Device Identifier
+ * @count:     Pointer to Context Loss counter to populate
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_dev_get_clcnt(const struct ti_sci_handle *handle, u32 id,
+                                   u32 *count)
+{
+       return ti_sci_get_device_state(handle, id, count, NULL, NULL, NULL);
+}
+
+/**
+ * ti_sci_cmd_dev_is_idle() - Check if the device is requested to be idle
+ * @handle:    Pointer to TISCI handle
+ * @id:                Device Identifier
+ * @r_state:   true if requested to be idle
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_dev_is_idle(const struct ti_sci_handle *handle, u32 id,
+                                 bool *r_state)
+{
+       int ret;
+       u8 state;
+
+       if (!r_state)
+               return -EINVAL;
+
+       ret = ti_sci_get_device_state(handle, id, NULL, NULL, &state, NULL);
+       if (ret)
+               return ret;
+
+       *r_state = (state == MSG_DEVICE_SW_STATE_RETENTION);
+
+       return 0;
+}
+
+/**
+ * ti_sci_cmd_dev_is_stop() - Check if the device is requested to be stopped
+ * @handle:    Pointer to TISCI handle
+ * @id:                Device Identifier
+ * @r_state:   true if requested to be stopped
+ * @curr_state:        true if currently stopped.
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_dev_is_stop(const struct ti_sci_handle *handle, u32 id,
+                                 bool *r_state,  bool *curr_state)
+{
+       int ret;
+       u8 p_state, c_state;
+
+       if (!r_state && !curr_state)
+               return -EINVAL;
+
+       ret =
+           ti_sci_get_device_state(handle, id, NULL, NULL, &p_state, &c_state);
+       if (ret)
+               return ret;
+
+       if (r_state)
+               *r_state = (p_state == MSG_DEVICE_SW_STATE_AUTO_OFF);
+       if (curr_state)
+               *curr_state = (c_state == MSG_DEVICE_HW_STATE_OFF);
+
+       return 0;
+}
+
+/**
+ * ti_sci_cmd_dev_is_on() - Check if the device is requested to be ON
+ * @handle:    Pointer to TISCI handle
+ * @id:                Device Identifier
+ * @r_state:   true if requested to be ON
+ * @curr_state:        true if currently ON and active
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_dev_is_on(const struct ti_sci_handle *handle, u32 id,
+                               bool *r_state,  bool *curr_state)
+{
+       int ret;
+       u8 p_state, c_state;
+
+       if (!r_state && !curr_state)
+               return -EINVAL;
+
+       ret =
+           ti_sci_get_device_state(handle, id, NULL, NULL, &p_state, &c_state);
+       if (ret)
+               return ret;
+
+       if (r_state)
+               *r_state = (p_state == MSG_DEVICE_SW_STATE_ON);
+       if (curr_state)
+               *curr_state = (c_state == MSG_DEVICE_HW_STATE_ON);
+
+       return 0;
+}
+
+/**
+ * ti_sci_cmd_dev_is_trans() - Check if the device is currently transitioning
+ * @handle:    Pointer to TISCI handle
+ * @id:                Device Identifier
+ * @curr_state:        true if currently transitioning.
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_dev_is_trans(const struct ti_sci_handle *handle, u32 id,
+                                  bool *curr_state)
+{
+       int ret;
+       u8 state;
+
+       if (!curr_state)
+               return -EINVAL;
+
+       ret = ti_sci_get_device_state(handle, id, NULL, NULL, NULL, &state);
+       if (ret)
+               return ret;
+
+       *curr_state = (state == MSG_DEVICE_HW_STATE_TRANS);
+
+       return 0;
+}
+
+/**
+ * ti_sci_cmd_set_device_resets() - command to set resets for device managed
+ *                                 by TISCI
+ * @handle:    Pointer to TISCI handle as retrieved by *ti_sci_get_handle
+ * @id:                Device Identifier
+ * @reset_state: Device specific reset bit field
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_set_device_resets(const struct ti_sci_handle *handle,
+                                       u32 id, u32 reset_state)
+{
+       struct ti_sci_msg_req_set_device_resets req;
+       struct ti_sci_msg_hdr *resp;
+       struct ti_sci_info *info;
+       struct ti_sci_xfer *xfer;
+       int ret = 0;
+
+       if (IS_ERR(handle))
+               return PTR_ERR(handle);
+       if (!handle)
+               return -EINVAL;
+
+       info = handle_to_ti_sci_info(handle);
+
+       xfer = ti_sci_setup_one_xfer(info, TI_SCI_MSG_SET_DEVICE_RESETS,
+                                    TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
+                                    (u32 *)&req, sizeof(req), sizeof(*resp));
+       if (IS_ERR(xfer)) {
+               ret = PTR_ERR(xfer);
+               dev_err(info->dev, "Message alloc failed(%d)\n", ret);
+               return ret;
+       }
+       req.id = id;
+       req.resets = reset_state;
+
+       ret = ti_sci_do_xfer(info, xfer);
+       if (ret) {
+               dev_err(info->dev, "Mbox send fail %d\n", ret);
+               return ret;
+       }
+
+       resp = (struct ti_sci_msg_hdr *)xfer->tx_message.buf;
+
+       if (!ti_sci_is_response_ack(resp))
+               return -ENODEV;
+
+       return ret;
+}
+
+/**
+ * ti_sci_cmd_get_device_resets() - Get reset state for device managed
+ *                                 by TISCI
+ * @handle:            Pointer to TISCI handle
+ * @id:                        Device Identifier
+ * @reset_state:       Pointer to reset state to populate
+ *
+ * Return: 0 if all went fine, else return appropriate error.
+ */
+static int ti_sci_cmd_get_device_resets(const struct ti_sci_handle *handle,
+                                       u32 id, u32 *reset_state)
+{
+       return ti_sci_get_device_state(handle, id, NULL, reset_state, NULL,
+                                      NULL);
+}
+
 /*
  * ti_sci_setup_ops() - Setup the operations structures
  * @info:      pointer to TISCI pointer
@@ -404,11 +782,24 @@ static void ti_sci_setup_ops(struct ti_sci_info *info)
 {
        struct ti_sci_ops *ops = &info->handle.ops;
        struct ti_sci_board_ops *bops = &ops->board_ops;
+       struct ti_sci_dev_ops *dops = &ops->dev_ops;
 
        bops->board_config = ti_sci_cmd_set_board_config;
        bops->board_config_rm = ti_sci_cmd_set_board_config_rm;
        bops->board_config_security = ti_sci_cmd_set_board_config_security;
        bops->board_config_pm = ti_sci_cmd_set_board_config_pm;
+
+       dops->get_device = ti_sci_cmd_get_device;
+       dops->idle_device = ti_sci_cmd_idle_device;
+       dops->put_device = ti_sci_cmd_put_device;
+       dops->is_valid = ti_sci_cmd_dev_is_valid;
+       dops->get_context_loss_count = ti_sci_cmd_dev_get_clcnt;
+       dops->is_idle = ti_sci_cmd_dev_is_idle;
+       dops->is_stop = ti_sci_cmd_dev_is_stop;
+       dops->is_on = ti_sci_cmd_dev_is_on;
+       dops->is_transitioning = ti_sci_cmd_dev_is_trans;
+       dops->set_device_resets = ti_sci_cmd_set_device_resets;
+       dops->get_device_resets = ti_sci_cmd_get_device_resets;
 }
 
 /**
index 24145e5034b80b92e4a3d5e30d8c96c3eb8db4f2..96d8946a0ab2c04c61432a0ca4302a77708fd781 100644 (file)
 #define TI_SCI_MSG_BOARD_CONFIG_SECURITY  0x000d
 #define TI_SCI_MSG_BOARD_CONFIG_PM     0x000e
 
+/* Device requests */
+#define TI_SCI_MSG_SET_DEVICE_STATE    0x0200
+#define TI_SCI_MSG_GET_DEVICE_STATE    0x0201
+#define TI_SCI_MSG_SET_DEVICE_RESETS   0x0202
+
 /**
  * struct ti_sci_msg_hdr - Generic Message Header for All messages and responses
  * @type:      Type of messages: One of TI_SCI_MSG* values
@@ -98,4 +103,97 @@ struct ti_sci_msg_board_config {
        u16 boardcfg_size;
 } __packed;
 
+/**
+ * struct ti_sci_msg_req_set_device_state - Set the desired state of the device
+ * @hdr:               Generic header
+ * @id:        Indicates which device to modify
+ * @reserved: Reserved space in message, must be 0 for backward compatibility
+ * @state: The desired state of the device.
+ *
+ * Certain flags can also be set to alter the device state:
+ * + MSG_FLAG_DEVICE_WAKE_ENABLED - Configure the device to be a wake source.
+ * The meaning of this flag will vary slightly from device to device and from
+ * SoC to SoC but it generally allows the device to wake the SoC out of deep
+ * suspend states.
+ * + MSG_FLAG_DEVICE_RESET_ISO - Enable reset isolation for this device.
+ * + MSG_FLAG_DEVICE_EXCLUSIVE - Claim this device exclusively. When passed
+ * with STATE_RETENTION or STATE_ON, it will claim the device exclusively.
+ * If another host already has this device set to STATE_RETENTION or STATE_ON,
+ * the message will fail. Once successful, other hosts attempting to set
+ * STATE_RETENTION or STATE_ON will fail.
+ *
+ * Request type is TI_SCI_MSG_SET_DEVICE_STATE, responded with a generic
+ * ACK/NACK message.
+ */
+struct ti_sci_msg_req_set_device_state {
+       /* Additional hdr->flags options */
+#define MSG_FLAG_DEVICE_WAKE_ENABLED   TI_SCI_MSG_FLAG(8)
+#define MSG_FLAG_DEVICE_RESET_ISO      TI_SCI_MSG_FLAG(9)
+#define MSG_FLAG_DEVICE_EXCLUSIVE      TI_SCI_MSG_FLAG(10)
+       struct ti_sci_msg_hdr hdr;
+       u32 id;
+       u32 reserved;
+
+#define MSG_DEVICE_SW_STATE_AUTO_OFF   0
+#define MSG_DEVICE_SW_STATE_RETENTION  1
+#define MSG_DEVICE_SW_STATE_ON         2
+       u8 state;
+} __packed;
+
+/**
+ * struct ti_sci_msg_req_get_device_state - Request to get device.
+ * @hdr:               Generic header
+ * @id:                Device Identifier
+ *
+ * Request type is TI_SCI_MSG_GET_DEVICE_STATE, responded device state
+ * information
+ */
+struct ti_sci_msg_req_get_device_state {
+       struct ti_sci_msg_hdr hdr;
+       u32 id;
+} __packed;
+
+/**
+ * struct ti_sci_msg_resp_get_device_state - Response to get device request.
+ * @hdr:               Generic header
+ * @context_loss_count: Indicates how many times the device has lost context. A
+ *     driver can use this monotonic counter to determine if the device has
+ *     lost context since the last time this message was exchanged.
+ * @resets: Programmed state of the reset lines.
+ * @programmed_state:  The state as programmed by set_device.
+ *                     - Uses the MSG_DEVICE_SW_* macros
+ * @current_state:     The actual state of the hardware.
+ *
+ * Response to request TI_SCI_MSG_GET_DEVICE_STATE.
+ */
+struct ti_sci_msg_resp_get_device_state {
+       struct ti_sci_msg_hdr hdr;
+       u32 context_loss_count;
+       u32 resets;
+       u8 programmed_state;
+#define MSG_DEVICE_HW_STATE_OFF                0
+#define MSG_DEVICE_HW_STATE_ON         1
+#define MSG_DEVICE_HW_STATE_TRANS      2
+       u8 current_state;
+} __packed;
+
+/**
+ * struct ti_sci_msg_req_set_device_resets - Set the desired resets
+ *                             configuration of the device
+ * @hdr:               Generic header
+ * @id:        Indicates which device to modify
+ * @resets: A bit field of resets for the device. The meaning, behavior,
+ *     and usage of the reset flags are device specific. 0 for a bit
+ *     indicates releasing the reset represented by that bit while 1
+ *     indicates keeping it held.
+ *
+ * Request type is TI_SCI_MSG_SET_DEVICE_RESETS, responded with a generic
+ * ACK/NACK message.
+ */
+struct ti_sci_msg_req_set_device_resets {
+       struct ti_sci_msg_hdr hdr;
+       u32 id;
+       u32 resets;
+} __packed;
+
 #endif /* __TI_SCI_H */
index dd88f646ed69c066d194fcd90b862b5eae28ca0a..b2a45cd9ae16d508bd52aac83fdd6a10f8cad158 100644 (file)
@@ -57,12 +57,93 @@ struct ti_sci_board_ops {
                               u64 addr, u32 size);
 };
 
+/**
+ * struct ti_sci_dev_ops - Device control operations
+ * @get_device: Command to request for device managed by TISCI
+ *             Returns 0 for successful exclusive request, else returns
+ *             corresponding error message.
+ * @idle_device: Command to idle a device managed by TISCI
+ *             Returns 0 for successful exclusive request, else returns
+ *             corresponding error message.
+ * @put_device:        Command to release a device managed by TISCI
+ *             Returns 0 for successful release, else returns corresponding
+ *             error message.
+ * @is_valid:  Check if the device ID is a valid ID.
+ *             Returns 0 if the ID is valid, else returns corresponding error.
+ * @get_context_loss_count: Command to retrieve context loss counter - this
+ *             increments every time the device looses context. Overflow
+ *             is possible.
+ *             - count: pointer to u32 which will retrieve counter
+ *             Returns 0 for successful information request and count has
+ *             proper data, else returns corresponding error message.
+ * @is_idle:   Reports back about device idle state
+ *             - req_state: Returns requested idle state
+ *             Returns 0 for successful information request and req_state and
+ *             current_state has proper data, else returns corresponding error
+ *             message.
+ * @is_stop:   Reports back about device stop state
+ *             - req_state: Returns requested stop state
+ *             - current_state: Returns current stop state
+ *             Returns 0 for successful information request and req_state and
+ *             current_state has proper data, else returns corresponding error
+ *             message.
+ * @is_on:     Reports back about device ON(or active) state
+ *             - req_state: Returns requested ON state
+ *             - current_state: Returns current ON state
+ *             Returns 0 for successful information request and req_state and
+ *             current_state has proper data, else returns corresponding error
+ *             message.
+ * @is_transitioning: Reports back if the device is in the middle of transition
+ *             of state.
+ *             -current_state: Returns 'true' if currently transitioning.
+ * @set_device_resets: Command to configure resets for device managed by TISCI.
+ *             -reset_state: Device specific reset bit field
+ *             Returns 0 for successful request, else returns
+ *             corresponding error message.
+ * @get_device_resets: Command to read state of resets for device managed
+ *             by TISCI.
+ *             -reset_state: pointer to u32 which will retrieve resets
+ *             Returns 0 for successful request, else returns
+ *             corresponding error message.
+ *
+ * NOTE: for all these functions, the following parameters are generic in
+ * nature:
+ * -handle:    Pointer to TISCI handle as retrieved by *ti_sci_get_handle
+ * -id:                Device Identifier
+ *
+ * Request for the device - NOTE: the client MUST maintain integrity of
+ * usage count by balancing get_device with put_device. No refcounting is
+ * managed by driver for that purpose.
+ */
+struct ti_sci_dev_ops {
+       int (*get_device)(const struct ti_sci_handle *handle, u32 id);
+       int (*idle_device)(const struct ti_sci_handle *handle, u32 id);
+       int (*put_device)(const struct ti_sci_handle *handle, u32 id);
+       int (*is_valid)(const struct ti_sci_handle *handle, u32 id);
+       int (*get_context_loss_count)(const struct ti_sci_handle *handle,
+                                     u32 id, u32 *count);
+       int (*is_idle)(const struct ti_sci_handle *handle, u32 id,
+                      bool *requested_state);
+       int (*is_stop)(const struct ti_sci_handle *handle, u32 id,
+                      bool *req_state, bool *current_state);
+       int (*is_on)(const struct ti_sci_handle *handle, u32 id,
+                    bool *req_state, bool *current_state);
+       int (*is_transitioning)(const struct ti_sci_handle *handle, u32 id,
+                               bool *current_state);
+       int (*set_device_resets)(const struct ti_sci_handle *handle, u32 id,
+                                u32 reset_state);
+       int (*get_device_resets)(const struct ti_sci_handle *handle, u32 id,
+                                u32 *reset_state);
+};
+
 /**
  * struct ti_sci_ops - Function support for TI SCI
  * @board_ops: Miscellaneous operations
+ * @dev_ops:   Device specific operations
  */
 struct ti_sci_ops {
        struct ti_sci_board_ops board_ops;
+       struct ti_sci_dev_ops dev_ops;
 };
 
 /**