]> git.baikalelectronics.ru Git - kernel.git/commitdiff
cx82310_eth: fix error return code in cx82310_bind()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Fri, 13 Nov 2020 06:07:07 +0000 (14:07 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 16 Nov 2020 23:23:44 +0000 (15:23 -0800)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 7226f009ee48 ("cx82310_eth: re-enable ethernet mode after router reboot")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1605247627-15385-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/cx82310_eth.c

index ca89d8258dd3f521b51f3ec3edbda697ef884cbf..c4568a491dc4debc62e4207d78f87f6c22606d6c 100644 (file)
@@ -197,7 +197,8 @@ static int cx82310_bind(struct usbnet *dev, struct usb_interface *intf)
        }
 
        /* enable ethernet mode (?) */
-       if (cx82310_enable_ethernet(dev))
+       ret = cx82310_enable_ethernet(dev);
+       if (ret)
                goto err;
 
        /* get the MAC address */