]> git.baikalelectronics.ru Git - kernel.git/commitdiff
platform/x86/amd/pmf: update to auto-mode limits only after AMT event
authorShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Wed, 25 Jan 2023 09:59:34 +0000 (15:29 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2023 10:28:06 +0000 (11:28 +0100)
[ Upstream commit 3dfe28c936f87373a2b6ada750be4c52c0f249f3 ]

Auto-mode thermal limits should be updated only after receiving the AMT
event. But due to a bug in the older commit, these settings were getting
applied during the auto-mode init.

Fix this by removing amd_pmf_set_automode() during auto-mode
initialization.

Fixes: 8b74ceda9840 ("platform/x86/amd/pmf: Add support for Auto mode feature")
Suggested-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230125095936.3292883-4-Shyam-sundar.S-k@amd.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/amd/pmf/auto-mode.c

index 644af42e07cf8168dee748042c5f92698fbc59a2..85ce9ed25b85779ab24ac2de7abbb8b4d1c7e0c4 100644 (file)
@@ -299,7 +299,5 @@ void amd_pmf_deinit_auto_mode(struct amd_pmf_dev *dev)
 void amd_pmf_init_auto_mode(struct amd_pmf_dev *dev)
 {
        amd_pmf_load_defaults_auto_mode(dev);
-       /* update the thermal limits for Automode */
-       amd_pmf_set_automode(dev, config_store.current_mode, NULL);
        amd_pmf_init_metrics_table(dev);
 }