]> git.baikalelectronics.ru Git - kernel.git/commitdiff
perf top: Tell the user how to unfreeze events after pressing 'f'
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 19 Jun 2015 20:35:25 +0000 (17:35 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 19 Jun 2015 21:13:59 +0000 (18:13 -0300)
When the user presses 'f' to disable events the visual cues are, well,
the percentages not changing and the number of events freezing.

Be more explicit by changing the help line at the bottom of the screen
to show the following messages when 'f' is pressed:

  "Press 'f' again to re-enable the events"

And then, when 'f' is pressed again:

  "Press 'f' to disable the events or 'h'

Suggested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-uhiswg9a9rxm5gxg7ptjskjn@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c

index ccf569ab08aaa4267390fda9887040c4ce17aa10..70a9505aae8349db8422c10690c8ece4543acdb6 100644 (file)
@@ -599,7 +599,13 @@ static void *display_thread_tui(void *arg)
                 * No need to refresh, resort/decay histogram entries
                 * if we are not collecting samples:
                 */
-               hbt.refresh = top->evlist->enabled ? top->delay_secs : 0;
+               if (top->evlist->enabled) {
+                       hbt.refresh = top->delay_secs;
+                       help = "Press 'f' to disable the events or 'h' to see other hotkeys";
+               } else {
+                       help = "Press 'f' again to re-enable the events";
+                       hbt.refresh = 0;
+               }
        }
 
        done = 1;