ASoC: rsnd: Add check for rsnd_mod_power_on

As rsnd_mod_power_on() can return negative numbers,
it should be better to check the return value and
deal with the exception.

Fixes: e7d850dd10f4 ("ASoC: rsnd: use mod base common method on SSI-parent")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20220902013030.3691266-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sh/rcar/ctu.c b/sound/soc/sh/rcar/ctu.c
index 6156445bcb69a3e0297517986eb2e83ec6fd7876..e39eb2ac7e9554afd56d2a94dc32a1803ef03b2c 100644 (file)
--- a/sound/soc/sh/rcar/ctu.c
+++ b/sound/soc/sh/rcar/ctu.c
@@ -171,7 +171,11 @@ static int rsnd_ctu_init(struct rsnd_mod *mod,
                         struct rsnd_dai_stream *io,
                         struct rsnd_priv *priv)
 {
-       rsnd_mod_power_on(mod);
+       int ret;
+
+       ret = rsnd_mod_power_on(mod);
+       if (ret < 0)
+               return ret;
 
        rsnd_ctu_activation(mod);
 

diff --git a/sound/soc/sh/rcar/dvc.c b/sound/soc/sh/rcar/dvc.c
index 5137e03a9d7c71f2000c093b518711aa77673d51..16befcbc312cb7de8f863af54465832e2aff1804 100644 (file)
--- a/sound/soc/sh/rcar/dvc.c
+++ b/sound/soc/sh/rcar/dvc.c
@@ -186,7 +186,11 @@ static int rsnd_dvc_init(struct rsnd_mod *mod,
                         struct rsnd_dai_stream *io,
                         struct rsnd_priv *priv)
 {
-       rsnd_mod_power_on(mod);
+       int ret;
+
+       ret = rsnd_mod_power_on(mod);
+       if (ret < 0)
+               return ret;
 
        rsnd_dvc_activation(mod);
 

diff --git a/sound/soc/sh/rcar/mix.c b/sound/soc/sh/rcar/mix.c
index 3572c2c5686c7973d06b32f7b0a7fb471f868a8d..1de0e085804cc247f139e4f83bec86343e4df45b 100644 (file)
--- a/sound/soc/sh/rcar/mix.c
+++ b/sound/soc/sh/rcar/mix.c
@@ -146,7 +146,11 @@ static int rsnd_mix_init(struct rsnd_mod *mod,
                         struct rsnd_dai_stream *io,
                         struct rsnd_priv *priv)
 {
-       rsnd_mod_power_on(mod);
+       int ret;
+
+       ret = rsnd_mod_power_on(mod);
+       if (ret < 0)
+               return ret;
 
        rsnd_mix_activation(mod);
 

diff --git a/sound/soc/sh/rcar/src.c b/sound/soc/sh/rcar/src.c
index 0ea84ae57c6acbb0b23eed19eef33486e4066918..f832165e46bc04dc413086dc7bd8f57647f98a88 100644 (file)
--- a/sound/soc/sh/rcar/src.c
+++ b/sound/soc/sh/rcar/src.c
@@ -463,11 +463,14 @@ static int rsnd_src_init(struct rsnd_mod *mod,
                         struct rsnd_priv *priv)
 {
        struct rsnd_src *src = rsnd_mod_to_src(mod);
+       int ret;
 
        /* reset sync convert_rate */
        src->sync.val = 0;
 
-       rsnd_mod_power_on(mod);
+       ret = rsnd_mod_power_on(mod);
+       if (ret < 0)
+               return ret;
 
        rsnd_src_activation(mod);
 

diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
index 43c5e27dc5c869716b861dadf0d65c21d6019187..7ade6c5ed96ff239b8ab91fa67c41a6f0b59008c 100644 (file)
--- a/sound/soc/sh/rcar/ssi.c
+++ b/sound/soc/sh/rcar/ssi.c
@@ -480,7 +480,9 @@ static int rsnd_ssi_init(struct rsnd_mod *mod,
 
        ssi->usrcnt++;
 
-       rsnd_mod_power_on(mod);
+       ret = rsnd_mod_power_on(mod);
+       if (ret < 0)
+               return ret;
 
        rsnd_ssi_config_init(mod, io);