]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/nouveau/gr/gf100-: change gf108_gr_fwif from global to static
authorTom Rix <trix@redhat.com>
Mon, 18 Apr 2022 15:28:10 +0000 (11:28 -0400)
committerLyude Paul <lyude@redhat.com>
Mon, 18 Apr 2022 18:54:13 +0000 (14:54 -0400)
Smatch reports this issue
gf108.c:147:1: warning: symbol 'gf108_gr_fwif'
  was not declared. Should it be static?

gf108_gr_fwif is only used in gf108.c.  Single
file variables should not be global so change
gf108_gr_fwif's storage-class specifier to static.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220418152810.3280502-1-trix@redhat.com
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf108.c

index 030640bb3dca073c4592dbb7502b3a100c83f907..ab3760e804b8a64c2ba784179ec8a92e7a5645c3 100644 (file)
@@ -143,7 +143,7 @@ gf108_gr = {
        }
 };
 
-const struct gf100_gr_fwif
+static const struct gf100_gr_fwif
 gf108_gr_fwif[] = {
        { -1, gf100_gr_load, &gf108_gr },
        { -1, gf100_gr_nofw, &gf108_gr },