]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: hns3: don't push link state to VF if unalive
authorJian Shen <shenjian15@huawei.com>
Sat, 11 Jun 2022 12:25:25 +0000 (20:25 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Jun 2022 10:56:01 +0000 (11:56 +0100)
It's unnecessary to push link state to unalive VF, and the VF will
query link state from PF when it being start works.

Fixes: 2d9269b81d97 ("net: hns3: PF add support for pushing link status to VFs")
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index fc0265b63331582083708a55227641612b302ab1..2e891b837c51eb7d9f5ef6401ce59ba693645bd7 100644 (file)
@@ -3376,6 +3376,12 @@ static int hclge_set_vf_link_state(struct hnae3_handle *handle, int vf,
        link_state_old = vport->vf_info.link_state;
        vport->vf_info.link_state = link_state;
 
+       /* return success directly if the VF is unalive, VF will
+        * query link state itself when it starts work.
+        */
+       if (!test_bit(HCLGE_VPORT_STATE_ALIVE, &vport->state))
+               return 0;
+
        ret = hclge_push_vf_link_status(vport);
        if (ret) {
                vport->vf_info.link_state = link_state_old;